Adapt setup.py for pypa/setuptools@2db55275f#6036
Conversation
github-actions
bot
added
the
benchmark_this
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6036 +/- ##
=======================================
Coverage 89.77% 89.77%
=======================================
Files 90 90
Lines 22984 22984
Branches 5031 5031
=======================================
Hits 20634 20634
Misses 1619 1619
Partials 731 731 ☔ View full report in Codecov by Sentry. |
HGWright
left a comment
HGWright
left a comment
There was a problem hiding this comment.
Approving and merging this while the benchmarks are still in progress, since a full run is not necessary to test the change that we have made. We just wanted to make sure that the benchmarks could run and iris could be installed. (This is something that changing setup.py could affect.) We have confirmed that the benchmarks have completed full runs with this commit checked out and is able to run the benchmarks where as the commit on main is having benchmarks fail, (the change that we are making fixed that).
* upstream/main: Quieter datum warning (SciTools#6050) Allow MeshCoord to have a coord-system (SciTools#6016) Bump scitools/workflows from 2024.07.1 to 2024.07.2 (SciTools#6053) Faster concatenation of cubes with `AuxCoordFactory`s (SciTools#6038) Shorten cube iterator tests (SciTools#6041) Bump scitools/workflows from 2024.07.0 to 2024.07.1 (SciTools#6045) Bump scitools/workflows from 2024.06.5 to 2024.07.0 (SciTools#6034) Update test_Saver__ugrid.py (SciTools#6017) NEP29 and NumPy v2 pins (SciTools#6039) Adapt setup.py for pypa/setuptools@2db55275f. (SciTools#6036) Replace DelegatedConda with Delegated (SciTools#5963) Enable type hint checking (SciTools#5956) Bump scitools/workflows from 2024.06.4 to 2024.06.5 (SciTools#6026) Do not realize cell measures and ancillary variables in concatenate (SciTools#6010) [pre-commit.ci] pre-commit autoupdate (SciTools#6022) Bump scitools/workflows from 2024.06.3 to 2024.06.4 (SciTools#6018)
2 participants
🚀 Pull Request
Description
We were mistakenly passing a tuple into something that needed a list - needs to be a mutable object.
pypa/setuptools@2db55275f
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: